fix: prevent editable base branch dropdown from being clipped#340
Merged
ping-maxwell merged 2 commits intobetter-auth:mainfrom Apr 7, 2026
Merged
Conversation
|
@AbhiVarde is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
ping-maxwell
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The base branch dropdown was clipped by a parent scroll container on the PR detail page, causing it to appear cut off when opened.
Solution
Changed dropdown from
absolutetofixedpositioning usingtriggerRefto calculate the exact viewport position, so it always renders above parent scroll containers.Files Changed
apps/web/src/components/pr/editable-base-branch.tsxScreenshots